Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gefs until rewrite in gefs_factor branch can be finished. #336

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

potterzot
Copy link
Contributor

This PR removes R/gefs.R and tests/testthat/test-gefs.R to resolve CRAN issues until a working rewrite can be finished. This PR is a result of issue #335, but the fix should also address #332.

@sckott sckott added this to the v0.9.5 milestone Nov 19, 2019
@sckott
Copy link
Contributor

sckott commented Nov 19, 2019

thanks @potterzot - i'll add back gefs fxns with a .Defunct() call in them so that users will have a meainginful message about whats happened.

@sckott sckott merged commit 7df7ac3 into ropensci:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants