Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectors ghcnd #373

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Vectors ghcnd #373

merged 4 commits into from
Oct 14, 2020

Conversation

eliocamp
Copy link
Contributor

This is a (hopefully) cleaner version of #356 .

@sckott sckott added this to the v1.3 milestone Oct 13, 2020
@sckott sckott added the ghcnd label Oct 13, 2020
sckott
sckott suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@sckott sckott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! can you also:

  • update the stationid parameter definition to rephrase to indicate that more than 1 stationid can be passed in

R/ghcnd.R Outdated Show resolved Hide resolved
@eliocamp
Copy link
Contributor Author

There!

@sckott
Copy link
Contributor

sckott commented Oct 14, 2020

thanks!

@sckott sckott merged commit 3954d66 into ropensci:master Oct 14, 2020
sckott added a commit that referenced this pull request Oct 14, 2020
@sckott
bump version for the last PR #373
f118fe3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sckott sckott sckott approved these changes

Assignees
No one assigned
Labels
ghcnd
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@eliocamp @sckott