Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new editors post #52

Merged
merged 21 commits into from
Oct 27, 2020
Merged

new editors post #52

merged 21 commits into from
Oct 27, 2020

Conversation

stefaniebutland
Copy link
Member

No description provided.

@stefaniebutland
Copy link
Member Author

Dearest @maelle, how do I make class = "pull-left" on an image not pull everything after it?
Please see preview

@maelle
Copy link
Member

maelle commented Oct 8, 2020

Interesting! I think mostly we need more text in the bio, as seen in the section about Laura now. But in any case I'd also recommend using the imgtxt shortcode which I've done for Julia and Mauro: the alignment looks better.

maelle
maelle reviewed Oct 8, 2020
View reviewed changes
data/team/team.json Outdated Show resolved Hide resolved
@stefaniebutland
Copy link
Member Author

I'd also recommend using the imgtxt shortcode which I've done for Julia and Mauro: the alignment looks better.

Yes it does!
I started to change to imgtxt shortcode and then figured I should do pull-left to test what we wrote in blog guide.

Thank you for those tests and edits.

@stefaniebutland stefaniebutland mentioned this pull request Oct 8, 2020
Closed
maurolepore added a commit that referenced this pull request Oct 17, 2020
@maurolepore
Add 'orcid' and 'img' to maurolepore's page
259f7fe 
Relates to #52

I added my orcid and img url based on @maelle's author page:
https://raw.githubusercontent.com/ropensci/roweb3/master/content/author/ma%C3%ABlle-salmon/_index.md

This change reponds to this request by @stefaniebutland:

> Check your rOpenSci author page and request any changes (by
> reply to this email or by pull request).
@maurolepore maurolepore mentioned this pull request Oct 17, 2020
Merged
Julia Gustavsen and others added 3 commits October 18, 2020 14:52
add JAG bio to blog post and update JAG author page
38a4745
@maurolepore
Add maurolepore's bio and quote
da0fd1d 
This responds to this request by @stefaniebutland:

> What do I need from you by Mon Oct 19th?
> - your short bio, or link to one I can copy/paraphrase
> - a short quote from you - can be anything about code review or why you are willing to volunteer
>  your time, experience, and expertise to do this (see the posts above)
@stefaniebutland
Merge pull request #64 from jooolia/stef-editors_JAG-additions
3bd5726 
add JAG bio to blog post and update JAG author page
@stefaniebutland
Copy link
Member Author

@maurolepore @ldecicco-USGS @jooolia Thank you for your bios and your generous quotes. Here's the preview of the post.

Please review by Fri Oct 23 if possible (before Mon Oct 26 is ok). No edits required, but you're welcome to request/make edits using commit suggestions or comments.

Items to consider

  • check each other's bios to see if you want to edit yours
  • fyi Julia your rOpenSci author page will be live on Thurs Oct 22.
  • Julia, the others listed packages they reviewed & edited, so you could add those if you like (not required; links below if you want to add)

I made these changes

  • Laura, I added links to unconf blog posts and packages reviews to your bio
  • Mauro, I fixed a typo and changed tense in bio to clarify

@stefaniebutland stefaniebutland marked this pull request as ready for review October 20, 2020 18:07
@stefaniebutland stefaniebutland requested a review from a team as a code owner October 20, 2020 18:07
@stefaniebutland stefaniebutland removed the request for review from a team October 20, 2020 18:07
maurolepore
maurolepore approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks!

@ldecicco-USGS ldecicco-USGS self-requested a review October 20, 2020 22:34
@jooolia jooolia mentioned this pull request Oct 24, 2020
Merged
@stefaniebutland
Merge pull request #67 from jooolia/stef-editors_JAG_take2
e7b1fab 
Added JAG package reviews to intro editor blog post.
@stefaniebutland stefaniebutland merged commit 2281d1b into master Oct 27, 2020
@stefaniebutland stefaniebutland deleted the stef-editors branch October 27, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelle maelle maelle left review comments

@ldecicco-USGS ldecicco-USGS ldecicco-USGS approved these changes

@maurolepore maurolepore maurolepore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stefaniebutland @maelle @ldecicco-USGS @maurolepore @jooolia