-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submission: qualtRics #192
Comments
Editor checks:
Editor commentsWe understand your desire to keep function names the same to avoid breaking code for current users. The exception is noted. Thanks for switching to the rOpenSci headers. Below are the comments from
Reviewer 1: @kierisi Reviewer 2: @trinker |
Hi Karthik, Thanks for your comments. I fixed the following gp feedback:
Partially fixed or left as is:
I've added the latest gp output below. GP qualtRics It is good practice to ✖ write unit tests for all functions, and all package code in general. 56% of code lines are covered by test cases.
✖ avoid long code lines, it is bad for readability. Also, many people prefer editor windows that are about 80 characters
✖ avoid calling setwd(), it changes the global environment. If you need it, consider using on.exit() to restore the
✖ fix this R CMD check WARNING: LaTeX errors when creating PDF version. This typically indicates Rd problems. LaTeX |
Just a note regarding long lines that can only be long lines like error messages, you can add |
Reviewed all lines and added |
Reviewer 2 is @trinker (due date: by March 7th) |
Package ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
Functionality
Final approval (post-review)
Estimated hours spent reviewing: 3 Review CommentsThis package allows an R user to access Qualtrics survey data quickly and easily within R by using the Qualtrics API feature. As an avid Qualtrics user, I was pleasantly surprised with how quickly and seamlessly I was able to access survey data for analysis, because this is normally a tedious and time-consuming task. I tested the package using surveys of various:
Overall I encountered no difficulty in installing and using the package, even when testing complex surveys with high response rates. As indicated above, a statement of need has not yet been provided by the package authors. From my perspective, this package addresses several major needs often encountered by analysts who use R to work with Qualtrics data. Speaking broadly, Qualtrics itself can be quite finnicky in how it handles survey response data outside of Qualtrics. The qualtRics package helps mitigate this through the following methods:
TestsUsing
Documentation/vignetteThe explanation on registering Qualtrics credentials and creating a configuration file are aces. Providing links on where to find the Qualtrics API token that lead to Qualtrics help documentation reinforces what Qualtrics should be providing support on vs. what the package authors can provide support on. Help documentation and the vignette both provide good baseline information on the package and provide examples for the use of each function. I do recommend adding in line spacing to help improve the readability of the help documentation examples. |
Package ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
For packages co-submitting to JOSS
The package contains a
Functionality
Final approval (post-review)
Estimated hours spent reviewing: 4.5 hrs Review CommentsThanks for providing this interface to the R community. I was able to get up and running pretty quickly which is kudos considering I had never used Qualtrics and that the package is an API interface which can be tricky to have a smooth user interface. I have broken down additional comments into sub headings. FunctionalityThe package was pretty intuitive and easy to use. There were a few cognitive sticking points as I worked through the Vignette, README, and Examples that are in the form of suggestions below:
MessagesMessages (messages, warnings, and errors) were detailed and had suggestions for what to do.
README/VignetteBetween the README and Vignette I was up and running quickly. The links to the Qualtrics page for the
ExamplesExamples ran as expected with correct parameters and tweaks (examples with a package like this are difficult to do out of the box because every user's experience will be different). Nice job with making as generic as possible. I did note the following difficulties and/or suggestions:
CRAN SpecificationsThis appeared to pass CRAN checks. It does violate the following requirements in the Writing R Ext.:
ROpenSci Packaging GuidelinesThe package generally complies with ROpenSci's Packaging Guidelines (https://github.com/ropensci/onboarding/blob/master/packaging_guide.md). Code contains many comments for ease of understanding. There is little if any code duplication. I did note:
TestsTesting things that are secret (like API keys) is difficult. This package runs as many tests as possible. I did note:
|
Thanks for the reviews! I expect to start incorporating your feedback at the end of the week, as I'm currently wrapping up a project for a client. |
Thanks @JasperHG90! Looking forward to your revisions. |
Started working on revisions. Expect to finish by Friday 23 March at latest. |
Hello all, Thank you for your reviews. They were very useful. I've addressed most of them in the code (see the development branch), and have placed several comments/questions at the bottom of this post. Updates
Questions/comments
Could you provide a link/example?
|
@JasperHG90 Sorry for the lack of clarity on the lower cased titles:
What I mean is that cran states:
If you go to one of your files: https://github.com/JasperHG90/qualtRics/blob/master/R/getSurvey.R We see:
at line 17. This should not be lower cased but in title case:
This will then transfer to the .Rd files when you roxygenize. My thinking on the failed test is that it only fails for |
Thanks for your comments @trinker . I edited the titles. |
@kierisi Hi Jesse! 👋 Could you please take a look at @JasperHG90's recent changes and see if you are able to check off a statement of need issue? And please let us know if the fixes and updates are ok by you for a sign off. 🙏 |
clicked and on-board for a sign off 🚀 |
@trinker Do you have other concerns that remain unaddressed or are you happy to sign off as well? |
@karthik happy to sign off as well |
Approved! 🎉 Thank you for submitting and @kierisi and @trinker for thorough and timely reviews! 🙏 To-dos:
Welcome aboard! We'd also love a blog post about your package, either a short-form intro to it (https://ropensci.org/tech-notes/) or long-form post with more narrative about its development. ((https://ropensci.org/blog/). If you are, @stefaniebutland will be in touch about content and timing. |
To-dos:
|
Happy to write a technical note! |
@JasperHG90 Great to hear that you'd like to publish a technote on this. We can publish at any time (in contrast to blog posts that are scheduled). Please submit a draft by pull request at your convenience and we can review before publishing. Here are examples: https://ropensci.org/technotes/ Instructions on pull request and preview: https://github.com/ropensci/roweb2#contributing-a-blog-post. The only difference in YAML for technote is
I will add the topicid before publishing. Don't hesitate to ask any questions here. |
Hi Stefanie. Thanks for the information! |
@JasperHG90 One quick question. Would you be interested in adding @kierisi and @trinker as reviewers in your description file? Read more about why here Also would be good to see if they're both comfortable with the idea. e.g. https://github.com/ropensci/rdflib/blob/master/DESCRIPTION#L8-L10 |
fine by me! |
What a neat feature! If @kierisi and @trinker are OK, i’d Like to add them
as reviewers. Please leave information in a comment so I can add!
…On Wed, 11 Apr 2018 at 19:31, Karthik Ram ***@***.***> wrote:
@JasperHG90 <https://github.com/JasperHG90> One quick question. Would you
be interested in adding @kierisi <https://github.com/kierisi> and @trinker
<https://github.com/trinker> are reviewers in your description file? Read
more about why here
<https://ropensci.org/blog/2018/03/16/thanking-reviewers-in-metadata/>
Also would be good to see if they're both comfortable with the idea.
e.g. https://github.com/ropensci/rdflib/blob/master/DESCRIPTION#L9-L11
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#192 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHtJuw8OnBE_Trr4GLu2q0Au5dlyneVzks5tnj3TgaJpZM4R4hH5>
.
|
@kierisi @trinker If you don't already have an ORCID, sign up for one here: https://orcid.org/ |
here you go: 0000-0003-1915-9612 |
0000-0002-4299-7692 |
@karthik had one more question: could you explain to me how the JOSS process works? Is the accompanying paper automatically submitted or do I need to do something? Thanks! |
@JasperHG90 Sure. Just follow the submission instructions for JOSS (http://joss.theoj.org/papers/new) and submit a paper there. You'll need to write the paper of course, and include some high level references in a Then tag me as editor. I'll do a quick review of the paper itself and make sure it reads well. Once that's cleared, you will have to archive a copy of your repo in Zenodo (zenodo.org) and share the DOI. After that the EIC and I can finish the final steps for acceptance. |
@JasperHG90 I'm going to close this issue here but feel free to ping me over email (see my profile) for help with the JOSS part. 🙏 |
Paper is now published on JOSS! 🎉 http://joss.theoj.org/papers/10.21105/joss.00690 |
@JasperHG90 Are you still interested/ willing to write a tech note about |
Hi Stefanie, Thanks for your message. I'd be happy to do this but I am currently involved in a couple of projects that are taking up all of my time. Things should ease up around half August. I'll put this on the to-do list for around that time! Best, Jasper. |
I'll ping you here in late August then @JasperHG90 so we can come up with a tentative date for a draft. |
@JasperHG90 Hoping your projects load allows you some breathing room soon. |
Hi @JasperHG90. One last ping to ask if you want to write a |
Summary
This package focuses on the retrieval of survey data using the Qualtrics API and aims to reduce the pre-processing steps needed to prepare this data for analysis. It also supports the import of manual data exports and other metadata (survey flow, questions, number of responses etc.).
https://github.com/JasperHG90/qualtRics
I would categorise it under 'data retrieval', since the package allows users to retrieve data exports from Qualtrics and import this data directly into R.
Target audience are analysts who use Qualtrics to design and disseminate surveys and who want straightforward access to their data using the API.
yours differ or meet our criteria for best-in-category?
Not entirely. There are several packages that provide functionality to interact with the Qualtrics API, e.g.
However, I'm not sure if these packages are still under active development.
qualtRics
focuses entirely on importing survey data and attempts to make this as simple as possible. Furthermore, it is the only package that uses survey metadata to automatically convert survey questions.No pre-submission, but I was contacted by one of your colleagues who invited me to submit the package. See here
Requirements
Confirm each of the following by checking the box. This package:
Publication options
Already on CRAN. See CRAN page
paper.md
matching JOSS's requirements with a high-level description in the package root or ininst/
.Detail
R CMD check
(ordevtools::check()
) succeed? Paste and describe any errors or warnings:No warnings / errors
Yes with following notes:
Function names: these do not conform to the rOpenSci standards. I chose to keep them as is since this package has already been on CRAN for some time and changing the names of the functions would result in useless existing code for users.
News file: Until recently I used a Changelog.md file for news about changes. I'm now using rOpenSci headers for new releases, but have not done so for previous releases.
If this is a resubmission following rejection, please explain the change in circumstances:
If possible, please provide recommendations of reviewers - those with experience with similar packages and/or likely users of your package - and their GitHub user names:
The text was updated successfully, but these errors were encountered: