New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is depreciated getdRdTall function necessary? #103

Closed

DimmestP opened this issue Sep 30, 2021 · 1 comment · Fixed by #144

Collaborator

DimmestP commented Sep 30, 2021

From #85 Flic's code review

I didn't understand what's happening with last function getdRdTall(), presume getdRdTall() is deprecated, suggesting to use or instead using calculate_drdt_plate() instead? Is that correct? Not especially clear from reading the .R code though, perhaps could document this a little more? https://github.com/ewallace/tidyqpcr/blob/master/R/amp_melt_curve_functions.R#L125

DimmestP changed the title ~~Is depreceated getdRdTall function necessary?~~ Is depreciated getdRdTall function necessary?

Collaborator

ewallace commented Sep 30, 2021

No, it is not necessary. It was just included in order to not break some code/analysis previously.

We just have to double-check it’s not used, i.e. package passes checks and vignettes build with getdRdTall deleted.

ewallace added a commit that referenced this issue


          remove getdRdTall, fixes #103

ccf150c

ewallace linked a pull request

that will close this issue

calculate_drdt_plate fixes #104 #144

Merged

DimmestP closed this as completed in #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment