Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette packages and files for @kelshmo review #122

Closed
1 of 2 tasks
ewallace opened this issue Nov 30, 2021 · 0 comments · Fixed by #135
Closed
1 of 2 tasks

Vignette packages and files for @kelshmo review #122

ewallace opened this issue Nov 30, 2021 · 0 comments · Fixed by #135
Assignees
Labels
rOpensci-review To fix for rOpensci review, December 2021

Comments

@ewallace
Copy link
Collaborator

ewallace commented Nov 30, 2021

Responding to @kelshmo's review, ropensci/software-review#470 (comment)

In "Primers and probes calibration vignette" and "Multifactorial multi-plate qPCR analysis example"

  • Vignette needs ggplot2 loaded to run. For clarity, I might call library(cowplot) in the first code chunk too.
  • /inst will not exist for someone who has installed the package. There are a few references to files in /inst. Instead, you can use system.file() to find this file like you did at the beginning of the vignette: read_lightcycler_1colour_cq( "../inst/extdata/Edward_qPCR_Nrd1_calibration_2019-02-02_Ct.txt" )

@wolski also raised the point about file paths, so that is a priority. See ropensci/software-review#470 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rOpensci-review To fix for rOpensci review, December 2021
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants