Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress data 128 and uses system.file 122 #135

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

DimmestP
Copy link
Collaborator

Closes issue #122 and closes issue #128
- gzipped inst/extdata/*.txt
- add cowplot
- Cq replaces Ct in filenames
- read .txt.gz in vignettes
- Changes file names in example read_lightcycler function docs
- uses system.file in all extdata imports (issue #122)

I am not sure if I understand the second point in #122:
"Vignette needs ggplot2 loaded to run. For clarity, I might call library(cowplot) in the first code chunk too."

library(cowplot) is called in the first chunk already but this chunk is hidden from the vignette, should we just make it visible?

Copy link
Collaborator

@ewallace ewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happily approving this. It is wonderful to have the automatic checks on github and know that the vignettes re-build ok.

I moved the point about library(cowplot) to its own separate issue, #137.

@ewallace ewallace merged commit bd39b60 into ropensci:main Jan 11, 2022
@DimmestP DimmestP deleted the compress-data-128 branch January 11, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants