Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vignette titles from @wolski review #130

Closed
ewallace opened this issue Dec 17, 2021 · 0 comments · Fixed by #139
Closed

Fix vignette titles from @wolski review #130

ewallace opened this issue Dec 17, 2021 · 0 comments · Fixed by #139
Assignees
@ewallace
Labels
rOpensci-review To fix for rOpensci review, December 2021

Comments

@ewallace
Copy link
Collaborator

From @wolski review ropensci/software-review#470 (comment)

Rmarkdown and vignette title should be the same:
You have:
title: "Primers and probes calibration vignette"
%\VignetteIndexEntry{PrimerCalibration}
but better
title: "Primers and probes calibration vignette"
%\VignetteIndexEntry{Primers and probes calibration vignette}
@ewallace ewallace added the rOpensci-review To fix for rOpensci review, December 2021 label Dec 17, 2021
@ewallace ewallace mentioned this issue Jan 11, 2022
Closed
@ewallace ewallace self-assigned this Jan 11, 2022
ewallace added a commit that referenced this issue Jan 11, 2022
@ewallace
echo vignette setup fixes #137, titles fixes #130
64ec810
@ewallace ewallace mentioned this issue Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewallace ewallace

Labels
rOpensci-review To fix for rOpensci review, December 2021
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vignette tidying ropensci/tidyqpcr
1 participant
@ewallace