Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrity and metadata fixes #152 #154

Merged
merged 6 commits into from
May 4, 2022
Merged

Integrity and metadata fixes #152 #154

merged 6 commits into from
May 4, 2022

Conversation

ewallace
Copy link
Collaborator

fixes #152 https://github.com/ewallace/tidyqpcr/issues/152#issue-1205925988

  • DESCRIPTION, Depends on tidyr and fix version 0.4. (kept Imports on tibble because it makes the examples nicer and we use tibble in a LOT of examples)
  • added files to .Rbuildignore
  • replace LICENSE with LICENSE.md
  • load packages in tests with dplyr:: in front of relevant functions.
  • tidied test code, mostly linting / indenting
  • moved "getting started" further up in README.md
  • added top-level help file

@ewallace ewallace added the rOpensci-review To fix for rOpensci review, December 2021 label Apr 16, 2022
@ewallace ewallace requested a review from DimmestP April 16, 2022 09:52
@DimmestP DimmestP merged commit f707c5c into main May 4, 2022
@DimmestP DimmestP deleted the integrity-152 branch May 4, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimmestP DimmestP DimmestP approved these changes

Assignees
No one assigned
Labels
rOpensci-review To fix for rOpensci review, December 2021
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrity and metadata @jooolia review part 1
2 participants
@ewallace @DimmestP