rOpensci acceptance edits, addresses #188 #189
Conversation
|
Note: I think we should squash and merge this one when ready, to combine all the commits into a single update. |
There was a problem hiding this comment.
Fixed a minor typo. Happy with the edits. Although I am not sure what you meant in the tidyqpcr submission.
You can add this installation method to your package README install.packages("", repos = "https://ropensci.r-universe.dev/") thanks to R-universe. DID NOT DO this because I tried to install another ropensci package and dependencies didn't work. I don't know if it would work for ropensci.
I can download tidyqpcr perfectly fine using this method?
Also, the codecov badge doesn't work anymore because you need to give it access rights to the new repo (I dont have the admin right to do that, perhaps you do?). Otherwise, we might need to look into another way of presenting test coverage without needing to give codecov access.
|
Re: https://ropensci.r-universe.dev/ I could download packages from there but the dependencies didn't work so the package didn't work. Let's make that a separate issue ticket to test that with users' clean R installations... I'll check the codecov badge/access then merge. |
Edits to address #188
Which in turn is linked to ropensci/software-review#470
Requesting review from @DimmestP.