Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rOpenSci review by Aug24th #3

Merged
merged 79 commits into from
Aug 25, 2020
Merged

rOpenSci review by Aug24th #3

merged 79 commits into from
Aug 25, 2020

Conversation

cromanpa94
Copy link
Contributor

Additional information in:
ropensci/software-review#367

Cristian Román Palacios added 30 commits August 4, 2020 14:59
REVIEW:Type field deleted
07746cf
REVIEW: Title case
ff610ad
REVIEW: LICENSE updated
8b6250e
REVIEW:Multiline instructions removed
748ddde
Fix multiline as.treedata.table
59872e5
REVIEW:Booleans fixed in ifelse statements
9afe310
REVIEW:using inherits instead of class
1b5c188
REVIEW:Fix seq_along
700e0ed
REVIEW:message() instead of cat()
b99ea3c
REVIEW:paste0() within message() were removed
c7ebb3b
REVIEW:name_column argument fixed for "detect"
cb04cf5
REVIEW:testthat updated to include correct column auto-detection
54a8559
REVIEW:Message printing the auto-detected column
5b1951b
REVIEW:Changes based on style_pkg
d4cffa5
Remove new testthat
600752d
REVIEW:testthat updated to include correct column auto-detection (UPD…
e00fef9 
…ATED)
Review:remove repeatsAsDiscrete from detectCharacterType() and detect…
41f32f5 
…AllCharacters()
REVIEW:removed as.matrix() from detectAllCharacters
099a0a8
REVIEW:Test if the correct number of discrete/continuous characters a…
4752e44 
…re being found in the anolis dataset
REVIEW:Fixing 1: in forceNames()
96f84da
Back to e00fef9
d22efc2
REVIEW:Fixing additional Seq_along instead of 1:
9779592
REVIEW:Remove as.matrix from detectAllCharacters()
8d4b9e1
Using seq_len instead of 1:
19a777c
REVIEW:Test if the correct number of discrete/continuous characters
3cd17b9
REVIEW:promt removed in droptreedata.table
a6d0b60
remove extra line in summary.treedata.table()
23cfafe
REVIEW:extractVector simplified for ...
63a2935
REVIEW:tail() included. Additional changes-ROXIGENISE()
9b62811
extractVector examples updated
42491d2
wrightaprilm and others added 29 commits August 7, 2020 11:53
@wrightaprilm
REVIEW: long lines per gp()
bfb2572
@wrightaprilm
REVIEW: make spaces and tabs uniform with styler()
016bc06
@wrightaprilm
REVIEW: make tests compatible with 80-line limits
d860070
REVIEW:Removing charType from filterMatrix
3253251
REVIEW:Description added to detectCharacterType, detectCharacterChang…
ca94642 
…es, and filterMatrix
REVIEW:Vignette updated for filterMatrix, forceNames, and hasNames
9988f78
REVIEW:repeatsAsDiscrete removed
79cfcb4
REVIEW:more badges added
b38d88a
codecov updated
43450f1
codecov
3003e00
@cromanpa94
Add logo
42b58cf
@cromanpa94
Logo size
2a12a7d
@cromanpa94
Logo resized
7062a02
@cromanpa94
links and formatting
22b0f18
@cromanpa94
REVIEW:CRP to aut
16b6fbe
@cromanpa94
REVIEW:Missing ORCID added
b76f4a8
@cromanpa94
REVIEW: Hugo and Kari
44cceda
@cromanpa94
REVIEW:match.arg for oulltreedata.table
9408ac3
@cromanpa94
REVIEW:setDT removed
92bf3c8
@cromanpa94
REVIEW:Information on the Default added
fa8fd8f
@cromanpa94
REVIEW:Depends and Imports
3d43122
@cromanpa94
Fixing tips dropped from [
22eace9
@cromanpa94
Fixing tips dropped x2 [
be1a218
@cromanpa94
REVIEW:microbenchmark
3bd6574
@cromanpa94
FigSize
bee6c12
@cromanpa94
FigSize
479f04c
@cromanpa94
Figsize3
3f308e6
@cromanpa94
REVIEW:filterMatrix and droptreedata.table message
4917b4a
@cromanpa94
Bisaloo's comments
73e5c14
@cromanpa94 cromanpa94 merged commit 1d27bac into master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cromanpa94 @wrightaprilm