Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MuJoCo by FZI and AlgoryX #250

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Add MuJoCo by FZI and AlgoryX #250

merged 2 commits into from
Apr 2, 2024

Conversation

christophfroehlich
Copy link
Contributor

ros2_control system interface for MuJoCo. Not tested but looks great!

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble iron

Copy link
Contributor

mergify bot commented Feb 21, 2024

backport humble iron

✅ Backports have been created

@christophfroehlich christophfroehlich changed the title Add MuJoCo by FZI Add MuJoCo by FZI and AlgoryX Feb 21, 2024
@stefanscherzinger
Copy link

@christophfroehlich

Thanks for spotting and referencing that implementation! However, I'm afraid that's a little robot dependent at the moment. As far as I'm concerned, MuJoCo needs a specific configuration .xml that specifies the robot to simulate. We could adapt/change it to provide a more generic interface between MuJoCo and ros2_control so that users can simulate arbitrary robots (manipulators). I didn't continue this idea lately, but I'm interested in supporting/implementing if that's of use for the community.

@christophfroehlich
Copy link
Contributor Author

@christophfroehlich

Thanks for spotting and referencing that implementation! However, I'm afraid that's a little robot dependent at the moment. As far as I'm concerned, MuJoCo needs a specific configuration .xml that specifies the robot to simulate. We could adapt/change it to provide a more generic interface between MuJoCo and ros2_control so that users can simulate arbitrary robots (manipulators). I didn't continue this idea lately, but I'm interested in supporting/implementing if that's of use for the community.

For the scope of this PR it is fine like it is. It should just give a reference implementation for users on control.ros.org

I have a personal interest in bringing MuJoCo and ros2_control closer due to a research project I'm working on. But I haven't tried it out yet and can't comment on the limitations. @traversaro pointed me to google-deepmind/mujoco#1432, so I think there is more work to be done to provide a seamless integration like with Gazebo (classic). Once I have the time to work on that, I'd be happy to discuss future steps to find a more general solution.

@traversaro
Copy link

@traversaro pointed me to google-deepmind/mujoco#1432, so I think there is more work to be done to provide a seamless integration like with Gazebo (classic). Once I have the time to work on that, I'd be happy to discuss future steps to find a more general solution.

Just to complement the link, I think most of people using URDF with MuJoCo either manually or automatically change the URDF before the loading in MuJoCo, or the resulting .mjcf after the conversion, and that is why there are not a lot of discussion like google-deepmind/mujoco#1432 in MuJoCo issue tracker.

@christophfroehlich christophfroehlich merged commit 55de5ea into master Apr 2, 2024
5 checks passed
@christophfroehlich christophfroehlich deleted the add_mujoco branch April 2, 2024 22:18
mergify bot pushed a commit that referenced this pull request Apr 2, 2024
mergify bot pushed a commit that referenced this pull request Apr 2, 2024
christophfroehlich added a commit that referenced this pull request Apr 2, 2024
(cherry picked from commit 55de5ea)

Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich added a commit that referenced this pull request Apr 2, 2024
(cherry picked from commit 55de5ea)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants