Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework PID class API #246

Merged
merged 54 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
d24c7b6
Add computeCommand with double dt
christophfroehlich Dec 7, 2024
d351720
Calc dt only once
christophfroehlich Dec 7, 2024
59b65c6
Add specializations for duration types
christophfroehlich Dec 7, 2024
d883ab3
Format code
christophfroehlich Dec 7, 2024
a7773d5
Deprecate camelCase methods and add new overloads
christophfroehlich Dec 13, 2024
589a555
Merge branch 'ros2-master' into pid_double
christophfroehlich Dec 13, 2024
e18bc66
init_pid --> initialize
christophfroehlich Dec 13, 2024
0539f87
initialize
christophfroehlich Dec 13, 2024
c96b8df
Satisfy pre-commit
christophfroehlich Dec 13, 2024
8954660
Move function definitions to cpp file
christophfroehlich Dec 13, 2024
eb12319
Rename variables
christophfroehlich Dec 13, 2024
542b68a
Add tests for overloaded methods
christophfroehlich Dec 13, 2024
4c1ae85
Merge branch 'ros2-master' into pid_double
saikishor Dec 17, 2024
6cf88ab
Apply suggestions from code review
christophfroehlich Dec 17, 2024
49e192f
Make dt arguments const &
christophfroehlich Dec 17, 2024
f694d57
Rename initialize methods
christophfroehlich Dec 18, 2024
46e89a4
Disable deprecation warning of deprecated class member
christophfroehlich Dec 18, 2024
fc06593
Update comments
christophfroehlich Dec 18, 2024
44a8734
Apply suggestions from code review
christophfroehlich Dec 18, 2024
3d3bb50
Update docstring
christophfroehlich Dec 18, 2024
6d5df18
Merge branch 'ros2-master' into pid_double
christophfroehlich Jan 1, 2025
876907d
Cleanup includes
christophfroehlich Jan 1, 2025
23a86a4
Update comments and remove default constructor
christophfroehlich Jan 1, 2025
e869bd2
Merge branch 'ros2-master' into pid_double
christophfroehlich Jan 1, 2025
15e132a
Update docstring
christophfroehlich Jan 2, 2025
e2b2b7d
Merge branch 'ros2-master' into pid_double
christophfroehlich Jan 11, 2025
becdd42
Rename PidRos test files
christophfroehlich Jan 11, 2025
9dc0b52
Update docstrings
christophfroehlich Jan 21, 2025
1927e0b
Merge branch 'ros2-master' into pid_double
christophfroehlich Jan 21, 2025
027afb7
Update more occurrences of dt in the docstring
christophfroehlich Jan 22, 2025
27678d8
Update parameter description
christophfroehlich Jan 22, 2025
49d34f7
Update parameter description of PidRos
christophfroehlich Jan 22, 2025
cf73546
Update docstring again
christophfroehlich Jan 22, 2025
2aaab01
Readd old private methods to avoid ABI break
christophfroehlich Jan 23, 2025
188f3be
Readd default constructor to avoid ABI break
christophfroehlich Jan 23, 2025
7c0b9cc
Merge branch 'ros2-master' into pid_double
christophfroehlich Jan 23, 2025
fd0625b
Use new API for save_iterm code
christophfroehlich Jan 23, 2025
5722f93
Rename new initialize method to avoid ABI break
christophfroehlich Jan 23, 2025
c9e1a9b
Test ABI report uploader
christophfroehlich Jan 23, 2025
552d1f7
Always upload artifacts
christophfroehlich Jan 23, 2025
8bd79ee
Revert "Always upload artifacts"
christophfroehlich Jan 23, 2025
c25d294
Revert "Test ABI report uploader"
christophfroehlich Jan 23, 2025
49ca1ba
Move definition of deprecated methods to cpp file
christophfroehlich Jan 27, 2025
50854dc
Use a temporary copy to avoid ABI break
christophfroehlich Jan 27, 2025
6956fb9
Revert "Use a temporary copy to avoid ABI break"
christophfroehlich Jan 27, 2025
aaacf30
Change BASEDIR and upload artifacts
christophfroehlich Jan 28, 2025
6f0f937
Fix docstring
christophfroehlich Jan 28, 2025
1d21f80
Revert renaming of arguments for deprecated method
christophfroehlich Jan 28, 2025
30acd1b
Use implementation directly
christophfroehlich Jan 28, 2025
ee356de
const& in publish_pid_state
christophfroehlich Jan 28, 2025
66a3cc0
Fix dt_ns in cpp file too
christophfroehlich Jan 28, 2025
15c94a4
Don't use const&
christophfroehlich Jan 28, 2025
c607dda
Revert "const& in publish_pid_state"
christophfroehlich Jan 28, 2025
2a336f1
Revert "Don't use const&"
christophfroehlich Jan 29, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/rolling-abi-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,9 @@ jobs:
ROS_REPO: testing
ABICHECK_URL: github:${{ github.repository }}#${{ github.base_ref }}
NOT_TEST_BUILD: true
BASEDIR: ${{ github.workspace }}/.work
- uses: actions/[email protected]
if: always()
with:
name: abi-checker-report-${{ matrix.ROS_DISTRO }}
path: ${{ github.workspace }}/.work/abicheck/${{ github.base_ref }}
10 changes: 5 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,12 @@ if(BUILD_TESTING)
ament_add_gmock(rate_limiter_tests test/rate_limiter.cpp)
target_link_libraries(rate_limiter_tests control_toolbox)

ament_add_gtest(pid_parameters_tests test/pid_parameters_tests.cpp)
target_link_libraries(pid_parameters_tests control_toolbox)
ament_add_gtest(pid_ros_parameters_tests test/pid_ros_parameters_tests.cpp)
target_link_libraries(pid_ros_parameters_tests control_toolbox)

ament_add_gtest(pid_publisher_tests test/pid_publisher_tests.cpp)
target_link_libraries(pid_publisher_tests control_toolbox)
ament_target_dependencies(pid_publisher_tests rclcpp_lifecycle)
ament_add_gtest(pid_ros_publisher_tests test/pid_ros_publisher_tests.cpp)
target_link_libraries(pid_ros_publisher_tests control_toolbox)
ament_target_dependencies(pid_ros_publisher_tests rclcpp_lifecycle)

## Control Filters
# exponential_filter
Expand Down
Loading