Fix the test criterion of test_arm #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport jazzy humble |
✅ Backports have been created
|
ahcorde
approved these changes
Jan 21, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit bd6e284)
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit bd6e284)
This was referenced Jan 21, 2025
ahcorde
pushed a commit
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit bd6e284) Co-authored-by: Christoph Fröhlich <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit bd6e284) Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess, depending on the CPU load, the JTC goal might succeed later than the criterion in the test_position executable -> the return code is -1 (interpreted as 255) -> test fails.
What I haven't fixed: somehow the gazebo system is not shut down properly if the test failed. Should it? This results in later tests failing also, because the system remains up in the runner.
Closes #452