Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RealtimeClock #261

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Remove RealtimeClock #261

merged 3 commits into from
Jan 30, 2025

Conversation

christophfroehlich
Copy link
Contributor

RealtimeClock got deprecated on Jazzy and Rolling with their sync within the last days.

Fixes #241 and closes #23

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.66%. Comparing base (2fbe2ea) to head (ed0848b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   70.72%   71.66%   +0.94%     
==========================================
  Files           9        8       -1     
  Lines         526      487      -39     
  Branches       87       77      -10     
==========================================
- Hits          372      349      -23     
+ Misses         99       91       -8     
+ Partials       55       47       -8     
Flag Coverage Δ
unittests 71.66% <ø> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

saikishor
saikishor previously approved these changes Jan 20, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we already did a release deprecating it.
I think we should be fine as we discussed

@christophfroehlich christophfroehlich merged commit 08a2235 into master Jan 30, 2025
10 of 11 checks passed
@christophfroehlich christophfroehlich deleted the rm/clock branch January 30, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is RealtimeClock() still needed with ROS 2? Hard coded loop rate
3 participants