-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve diagnostics strings #2078
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2078 +/- ##
==========================================
+ Coverage 89.53% 89.55% +0.01%
==========================================
Files 139 139
Lines 15124 15125 +1
Branches 1283 1283
==========================================
+ Hits 13542 13545 +3
- Misses 1095 1096 +1
+ Partials 487 484 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this?. If you are still fine with original text, let's go for it ;)
The other changes LGTM
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Thanks for the follow-up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I was working with diagnostics a bit, and found the error messages and descriptions a bit confusing. Maybe this enhances it a bit?