Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostics strings #2078

Merged
merged 4 commits into from
Mar 1, 2025
Merged

Improve diagnostics strings #2078

merged 4 commits into from
Mar 1, 2025

Conversation

christophfroehlich
Copy link
Contributor

I was working with diagnostics a bit, and found the error messages and descriptions a bit confusing. Maybe this enhances it a bit?

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.55%. Comparing base (4f0f300) to head (869dad3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
+ Coverage   89.53%   89.55%   +0.01%     
==========================================
  Files         139      139              
  Lines       15124    15125       +1     
  Branches     1283     1283              
==========================================
+ Hits        13542    13545       +3     
- Misses       1095     1096       +1     
+ Partials      487      484       -3     
Flag Coverage Δ
unittests 89.55% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 76.40% <0.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

saikishor
saikishor previously approved these changes Mar 1, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this?. If you are still fine with original text, let's go for it ;)

The other changes LGTM

Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
saikishor previously approved these changes Mar 1, 2025
@saikishor
Copy link
Member

Thanks for the follow-up

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit 3aa38b0 into master Mar 1, 2025
26 of 27 checks passed
@bmagyar bmagyar deleted the improve/diagnostics/strings branch March 1, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants