-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM] Add message field to the switch_controller
service
#2088
base: master
Are you sure you want to change the base?
[CM] Add message field to the switch_controller
service
#2088
Conversation
…s available" This reverts commit ca8e282.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2088 +/- ##
==========================================
- Coverage 89.54% 89.40% -0.14%
==========================================
Files 139 139
Lines 15125 15237 +112
Branches 1283 1292 +9
==========================================
+ Hits 13543 13622 +79
- Misses 1096 1125 +29
- Partials 486 490 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great, some minor comments
…is not in the desired state
Co-authored-by: Sai Kishor Kothakota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
As we discussed in the previous WG meeting, I've added the
message
field to the SwitchControllers service response. This message is also integrated into the CLI