Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Add message field to the switch_controller service #2088

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

As we discussed in the previous WG meeting, I've added the message field to the SwitchControllers service response. This message is also integrated into the CLI

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 67.69231% with 42 lines in your changes missing coverage. Please review.

Project coverage is 89.40%. Comparing base (3aa38b0) to head (4d16c0b).

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 67.69% 36 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2088      +/-   ##
==========================================
- Coverage   89.54%   89.40%   -0.14%     
==========================================
  Files         139      139              
  Lines       15125    15237     +112     
  Branches     1283     1292       +9     
==========================================
+ Hits        13543    13622      +79     
- Misses       1096     1125      +29     
- Partials      486      490       +4     
Flag Coverage Δ
unittests 89.40% <67.69%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/controller_manager/controller_manager.hpp 96.87% <ø> (ø)
controller_manager/src/controller_manager.cpp 75.74% <67.69%> (-0.53%) ⬇️

... and 2 files with indirect coverage changes

@saikishor saikishor marked this pull request as ready for review March 3, 2025 21:05
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, some minor comments

saikishor and others added 2 commits March 4, 2025 17:09
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants