Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Using UDP communication, some statements fail to match because line breaks are not cleanly filtered #174

Open
wants to merge 2 commits into
base: ros2
Choose a base branch
from
Open

[bug] Using UDP communication, some statements fail to match because line breaks are not cleanly filtered #174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3be20d
fix:Modify udp-break filtering
zymouse Jan 9, 2024
4d9eef2
fix: Using UDP communication, some statements fail to match because l…
May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libnmea_navsat_driver/nodes/nmea_socket_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def main(args=None):
data, remote_address = socket_.recvfrom(buffer_size)

# strip the data
data_list = data.decode("ascii").strip().split("\n")
zymouse marked this conversation as resolved.
Show resolved Hide resolved
data_list = data.decode("ascii").strip().split()

for data in data_list:

Expand All @@ -96,4 +96,4 @@ def main(args=None):
# This will break out of the recv-loop so we start another iteration of the connection-loop
break

socket_.close() # Close socket
socket_.close() # Close socket