Fix device registered point cloud generation #4
Conversation
|
Just commented on your commit piyushk@5f2b684. |
…tration is set to true
|
I have applied ros-drivers/rgbd_launch@06ec218 in |
|
I have tested the updated pull request with the Xtion and Kinect and can confirm it's working. One thing I don't like though is that we have made this complex launcher even more complex ... Maybe we can do a big makeover with your new proposal rgbd_launch, which I haven't inspected yet, but will do so soon. |
|
@bit-pirate I agree. I will start a discussion on improvements with rgbd_launch. @jonbinney v1.9.1 might have broken openni_launch for anybody using device registration. Can you test this pull request out? If you think it is ok, then we should release again. |
|
Works for me. Merging; will release in a moment. |
Fix device registered point cloud generation
|
Released: ros/rosdistro#1607 |
…drivers/openni_launch. See ros-drivers/openni_launch#30 (comment) for the decision for this change. Preserving commit history was attempted (using the method in http://www.pixelite.co.nz/article/extracting-file-folder-from-git-repository-with-full-git-history), but didn't seem to easily work due to ros-drivers/openni_launch#4 that resurrects the change made previously in a few files and somehow `git am` command stops. So unfortunately, instead of spending more time on trying to save the commit history, I suggest to move forward.
xyzrgb cloud generation broke #3 when device registration was enabled. This pull request fixes this.