Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/restructure ur_bringup #429

Closed
gavanderhoorn opened this issue Jun 12, 2019 · 3 comments
Closed

Cleanup/restructure ur_bringup #429

gavanderhoorn opened this issue Jun 12, 2019 · 3 comments

Comments

@gavanderhoorn
Copy link
Member

ur_bringup contains too many launch files, some of which are most likely no longer needed (such as the joint_limited variants).

Ideally there would be either a single launch file per robot variant, or even a single launch file that accepts a variant or model argument and loads the appropriate parameters and other launch files based on that.

Another issue to consider would be what to do with ur_bringup in general seeing as it's only actually usable with CB1 and CB2 controllers (due to the hard-dependency on ur_driver).

@gavanderhoorn
Copy link
Member Author

Related discusion about robot drivers and bringup packages: ros-industrial/ros_industrial_issues#49.

@gavanderhoorn
Copy link
Member Author

gavanderhoorn commented Jun 12, 2019

And related PRs (joint limits): #268 and #266.

@gavanderhoorn
Copy link
Member Author

This package has actually been removed, as the drivers would now be responsible for providing these .launch files.

Closing as a wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant