Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce longest valid segment fraction to accomodate non-limited version of the UR5 #266

Merged
merged 3 commits into from
Sep 12, 2017

Conversation

scottpaulin
Copy link
Contributor

0.01 is the value suggested by @davetcoleman. It looks like it works well for self-collisions. Some users may need to reduce this value if they have very small or thin obstacles.

@davetcoleman what are your thoughts on this?

0.05 is fine for the limited version of the UR5, but a little bit too big when using the full joint range.
@davetcoleman
Copy link
Contributor

Like I said before, its a simple tradeoff between computation time and the possibility of missing collisions. But it also depends on the size of your obstacles - I think this value is good and even think we should make it the default for future robot config packages: https://github.com/ros-planning/moveit/blob/091f766175fadb1fd4cdab405715237cfdc88f80/moveit_setup_assistant/src/tools/moveit_config_data.cpp#L409

@gavanderhoorn gavanderhoorn changed the base branch from indigo-devel to kinetic-devel September 12, 2017 22:44
@gavanderhoorn
Copy link
Member

Again a change for which no CI coverage is available.

@gavanderhoorn
Copy link
Member

Tested this locally. On even a moderately specced machine, I do not experience a significant difference between the current value (0.05) and the proposed one (0.01).

As there is consensus that decreasing the value is beneficial - and not only when planning with the non-joint-limited version of the urdfs - I'm merging this.

@gavanderhoorn gavanderhoorn merged commit e0f69fd into ros-industrial:kinetic-devel Sep 12, 2017
@gavanderhoorn
Copy link
Member

And bp to Indigo.

gavanderhoorn pushed a commit to gavanderhoorn/universal_robot that referenced this pull request Sep 12, 2017
@gavanderhoorn
Copy link
Member

And I forgot: thanks a bunch @scottpaulin for digging into the issues with the elbow and proposing this change to longest_valid_segment_fraction. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants