-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description view files #435
Add description view files #435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fmauch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could address the two small comments this could be merged.
Nice contribution 👍
This resolves ros-industrial#432 To avoid introducing another dependency, I copied the rviz configuration from industrial_robot_client.
As we use the joint_state_publisher, the robot_state_publisher and rviz inside the launch files, I added them as run-dependencies.
9eaec99
to
05d5e8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again 👍
looks like travis finally caught up.
Thanks @fmauch. 👍 🏅 |
This MR adds launch files for viewing the individual descriptions with zero overhead.