Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description view files #435

Merged

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Jul 2, 2019

This MR adds launch files for viewing the individual descriptions with zero overhead.

miguelprada
miguelprada previously approved these changes Jul 2, 2019
Copy link
Member

@miguelprada miguelprada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmauch!

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could address the two small comments this could be merged.

Nice contribution 👍

ur_description/launch/view_ur10.launch Outdated Show resolved Hide resolved
fmauch added 2 commits July 2, 2019 10:47

Verified

This commit was signed with the committer’s verified signature.
This resolves ros-industrial#432

To avoid introducing another dependency, I copied the rviz configuration
from industrial_robot_client.
As we use the joint_state_publisher, the robot_state_publisher and rviz
inside the launch files, I added them as run-dependencies.
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR 👍

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again 👍

looks like travis finally caught up.

@gavanderhoorn gavanderhoorn merged commit b2977d1 into ros-industrial:kinetic-devel Jul 2, 2019
@gavanderhoorn
Copy link
Member

Thanks @fmauch.

👍 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants