Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gazebo names consistent. #395

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Make Gazebo names consistent. #395

merged 2 commits into from
Feb 28, 2024

Conversation

kscottz
Copy link
Contributor

@kscottz kscottz commented Feb 20, 2024

Change Ignition into Gazebo where appropriate so we're consistent across documents.

@kscottz kscottz requested a review from clalancette February 20, 2024 22:31
rep-2000.rst Outdated
+----------------+----------------+----------------+----------+----------------+---------------+------------------+---------------------+
| Gazebo Classic | 11.x.x* | N/A | N/A | 11.0.0* | 11.x.x | 11.x.x* | N/A |
+----------------+----------------+----------------+----------+----------------+---------------+------------------+---------------------+
| Gazebo (Ign) | Fortress* | N/A | N/A | Fortress* | Fortress* | Fortress* | N/A |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should change this to explicitly call out "Ignition" (rather than just "Ign"), to be fully clear. @azeey what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, "Ignition" makes sense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I switched it to "Ignition" now. It still seems to render OK, so we'll go with that. I'll go ahead and approve and merge this.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette merged commit eb6329e into master Feb 28, 2024
1 check passed
@clalancette clalancette deleted the ign2gazebo branch February 28, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants