Add logic for excluding group workaround dependencies #1040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents the first step in the journey to proper support for group dependencies in
ros_buildfarm
. Specifically, it sets the mechanism by which we disable the existing "pre-resolved" group dependencies present in the package manifests in the source repositories.I chose the name
DISABLE_GROUPS_WORKAROUND
to act as the "feature flag" for a tool to use when expressing that it has support for group dependencies and doesn't want the pre-resolved dependencies to be present. I'm open to suggestions for a better name.An example of how the package manifests would be modified for this change:
All manifests which pre-resolve groups would need to change, which (I believe) includes all manifests containing a
<group_depend>
element.At present,
build_file.include_group_dependencies
is neverTrue
in production, so this flag should never be activated and no change in behavior is expected to any supported platforms or distributions.