change to set the locale via snippet and add support for debian #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'snippet/setup_locale.Dockerfile.em', | ||
| os_name=os_name, | ||
| os_code_name=os_code_name, | ||
| timezone=timezone if timezone else None, |
There was a problem hiding this comment.
Have you tried to expand this template which doesn't pass in a timezone variable?
There was a problem hiding this comment.
I can't test it since it's available in all templates here i'll remove the conditional loading since you're right this won't work with timezone unset.
|
updated to not be conditional on timezone since it's set by the wrapper here |
|
LGTM. Please squash before the merge. |
…lling locale before using it
tfoote
force-pushed
the
locale_for_debian
branch
from
759fca4 to
5106e70
Compare
tfoote
added a commit
that referenced
this pull request
Mar 14, 2016
change to set the locale via snippet and add support for debian
|
Fixup for hard coded os versions: be01b7f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debian does not have locales in the base image.
This is to fix builds like this: http://54.183.26.131:8080/job/Ksrc_debianjessie__visualization_msgs__debian_jessie__source/193/console