patch git-buildpackage in Yakkety to use tree timestamp #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,6 +45,12 @@ RUN echo "@today_str" | |||
| ))@ | |||
|
|
|||
| RUN python3 -u /tmp/wrapper_scripts/apt.py update-install-clean -q -y debhelper dpkg dpkg-dev git git-buildpackage python3-catkin-pkg python3-rosdistro python3-yaml | |||
| @[if os_name == 'ubuntu' and os_code_name == 'yakkety']@ | |||
| @# git-buildpackage in Yakkety has a bug resulting in using the current time for | |||
| @# the to be archived files resulting in non-deterministic checksums for the tarball | |||
There was a problem hiding this comment.
Sounds good to me. "for the to be archived files" is one phrase.
There was a problem hiding this comment.
line wrap got me, sorry for the noise
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851645;msg=43
While it is nasty to patch the buggy code like this it makes the jobs turn over: http://build.ros.org/job/Lsrc_uY__catkin__ubuntu_yakkety__source/11/