-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update plugin versions and fix groovy failures #418
Conversation
796502e
to
5f26513
Compare
5f26513
to
82c2e58
Compare
Got Lrel_reconfigure-jobs working finally. I'm going to merge this and regenerate / deploy all the jobs and see how it goes |
Have you checked the configuration from the other updated plugins? While they might not have such breaking changes they still need to be reviewed / updated. |
agreed, but I won't have time to do this today. If this fix allows us to get the buildfarm up for the weekend I'd be in favor of merging and deploying this and iterate on the rest of the plugins as soon as someone has time to do it |
@@ -61,7 +61,7 @@ if (views.size() != @(expected_num_views)) { | |||
throw new AbortException("Wrong number of view configs") | |||
} | |||
|
|||
views.each{ | |||
for (it in views) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is really odd that the iterator was not resolving. But at least the for loop works.
This can be merged once CI has passed. But the remaining tasks have to be followed up on asap:
|
yes I'm planning on creating an issue for 1 and one issue for 2 and 3 with a gist referring all the approval once the list is complete |
Note: this branch should be kept until all jobs have been reconfigured |
For now this patch only updates the plugin version.
But the plugin configurations still need to be reviewed and updated (especially for
groovy
) in order to be parsable with the new plugin versions.Fixes #417.