Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update plugin versions and fix groovy failures #418

Merged
merged 3 commits into from
Apr 14, 2017
Merged

Conversation

dirk-thomas
Copy link
Member

For now this patch only updates the plugin version.

But the plugin configurations still need to be reviewed and updated (especially for groovy) in order to be parsable with the new plugin versions.

Fixes #417.

@mikaelarguedas
Copy link
Contributor

Got Lrel_reconfigure-jobs working finally. I'm going to merge this and regenerate / deploy all the jobs and see how it goes

@dirk-thomas
Copy link
Member Author

Have you checked the configuration from the other updated plugins? While they might not have such breaking changes they still need to be reviewed / updated.

@mikaelarguedas
Copy link
Contributor

agreed, but I won't have time to do this today. If this fix allows us to get the buildfarm up for the weekend I'd be in favor of merging and deploying this and iterate on the rest of the plugins as soon as someone has time to do it

@@ -61,7 +61,7 @@ if (views.size() != @(expected_num_views)) {
throw new AbortException("Wrong number of view configs")
}

views.each{
for (it in views) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is really odd that the iterator was not resolving. But at least the for loop works.

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Apr 14, 2017

This can be merged once CI has passed.

But the remaining tasks have to be followed up on asap:

  • check the configuration of the remaining plugins
  • update the buildfarm deployment logic to install the diffutils archive
  • document the signatures which require approval (if it can't be automated)

@mikaelarguedas
Copy link
Contributor

yes I'm planning on creating an issue for 1 and one issue for 2 and 3 with a gist referring all the approval once the list is complete

@mikaelarguedas mikaelarguedas changed the title update plugin versions update plugin versions and fix groovy failures Apr 14, 2017
@mikaelarguedas mikaelarguedas merged commit 614a3c0 into master Apr 14, 2017
@mikaelarguedas
Copy link
Contributor

Note: this branch should be kept until all jobs have been reconfigured

@dirk-thomas dirk-thomas deleted the plugin_config branch April 15, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants