Add os_name argument to check_sync_criteria #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use the get_package_repo_data method in place of the current debian-specific one.
dirk-thomas
reviewed
Jan 31, 2020
dirk-thomas
approved these changes
Jan 31, 2020
7 tasks
cottsay
added a commit
that referenced
this pull request
Sep 16, 2021
* Python 2 support for run_check_sync_criteria_job.py was regressed in #726. * The wildcard pattern in the PR branch filter doesn't appear to work correctly when opening a PR between non-master branches. * We've historically had no CI for trigger and sync jobs, but we're hitting some issues that are only happening in those job types (and reconfigure ones, but those are hard to test here).
cottsay
added a commit
that referenced
this pull request
Sep 16, 2021
* Python 2 support for run_check_sync_criteria_job.py was regressed in #726. * The wildcard pattern in the PR branch filter doesn't appear to work correctly when opening a PR to a non-master branch. * We've historically had no CI for trigger and sync jobs, but we're hitting some issues that are only happening in those job types (and reconfigure ones, but those are hard to test here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the get_package_repo_data method in place of the current debian-specific one.
Since this involves changing the arguments to a script that is invoked by Jenkins jobs, I had to do it in a backwards-compatible way. If this change is approved, I'll open an issue to track follow-up changes to actually remove the deprecated behaviors at a later date.