-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the shared ccache optional #844
Conversation
It isn't obvious or expected that running buildfarm tasks locally (outside of Jenkins) could modify the local ccache of the user invoking the command. This change disables ccache sharing by default. It can be re-enabled using the newly added `shared_ccache` build file option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making sure the new option is documented. Looks good to me.
This PR disables the ccache sharing by default.. And am I right that there is no way to enable it for pre-release tests? |
This is disabled on build.ros.org and build.ros2.org. The approach implemented in Additional development is necessary to either secure the cache by enforcing that only authorized (signed) compilers are contributing to it, or making the cache local to only the package or job. Right now, we don't have any plans to implement either of those features. Pull requests are welcome, as always. |
Thanks for the clarification! I will try to add a CLI option for the generation scripts.. |
It isn't obvious or expected that running buildfarm tasks locally (outside of Jenkins) could modify the local ccache of the user invoking the command. This change disables ccache sharing by default. It can be re-enabled using the newly added
shared_ccache
build file option.