Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old directory structure that was a reference to an unused repo #881

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented May 13, 2021

@tfoote tfoote merged commit 82cf456 into master Aug 6, 2021
@tfoote tfoote deleted the cleanup_doc_dir branch August 6, 2021 01:50
@nuclearsandwich
Copy link
Contributor

Amusingly enough, this change did not deploy to the rosdoc2 job until three years later, and when it was, it introduced a breakage since there is no longer any cleanup of the cidfile which was previously removed when recursively removing the docker_containers directory.

nuclearsandwich added a commit that referenced this pull request May 17, 2024
We previously built container images in a docker_containers
subdirectory, but that directory and its cleanup were removed in #881
which results in the cidfile left in workspace between runs.
nuclearsandwich added a commit that referenced this pull request May 17, 2024
We previously built container images in a docker_containers
subdirectory, but that directory and its cleanup were removed in #881
which results in the cidfile left in workspace between runs.
nuclearsandwich added a commit that referenced this pull request May 17, 2024
We previously built container images in a docker_containers
subdirectory, but that directory and its cleanup were removed in #881
which results in the cidfile left in workspace between runs.
nuclearsandwich added a commit that referenced this pull request May 22, 2024
)

We previously built container images in a docker_containers
subdirectory, but that directory and its cleanup were removed in #881
which results in the cidfile left in workspace between runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants