Explicitly state no compatibility with flake8 >= 5.0.0 #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pycodestyle and pyflakes requirements added here are to deal with incompatibilities introduced in newer versions of those flake8 plugins with the older flake8 requirement of this package.
clalancette
reviewed
Aug 2, 2022
From an offline conversation: there are dependency couplings with the newer flake8 that pip doesn't seem to want to resolve for us, so it was necessary to pin that as well even though it's not a direct dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of flake8 drops API compatibility. We should eventually add support for the newer flake8, but this should keep CI running in the mean time.