build bdist_wheel, use twine for upload #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
approved these changes
May 7, 2018
|
@tfoote Thanks for the review. Looking for a couple more for this low-level change... |
mikaelarguedas
approved these changes
May 7, 2018
tfoote
reviewed
May 7, 2018
scripts/ros_release_python
Outdated
| print('# ' + ' '.join(upload_cmd)) | ||
| if upload: | ||
| subprocess.check_call(upload_cmd) | ||
|
|
||
| scp_cmd = ['scp', tarball, '[email protected]:/home/ros/data/download.ros.org/downloads/%s' % name] |
There was a problem hiding this comment.
We might want to drop this step of uploading to a custom location. It's now strongly recommended to host everything using the python infrastructure for security. This would be one less thing to automate and maintain.
If we do this we should remove the url from the setup.py files of the couple of packages that reference it.
There was a problem hiding this comment.
Sounds good to me. If others agree I can create PRs for them.
There was a problem hiding this comment.
Based on the offline meeting I removed the upload to downloads.ros.org in ed8efb3.
This was referenced May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the latest packaging guidelines this patch:
bdist_wheel(beside thesdist)twineUsers of this tool need to install
twinefor future releases.