Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quiet mode of debian installer #612

Merged
merged 2 commits into from
Jun 8, 2018
Merged

fix quiet mode of debian installer #612

merged 2 commits into from
Jun 8, 2018

Conversation

mathias-luedtke
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 6, 2018

Codecov Report

Merging #612 into master will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   75.27%   75.29%   +0.01%     
==========================================
  Files          30       30              
  Lines        2884     2882       -2     
==========================================
- Hits         2171     2170       -1     
+ Misses        713      712       -1
Impacted Files Coverage Δ
src/rosdep2/platforms/debian.py 85.71% <75%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cccca5d...d9ddcc4. Read the comment docs.

There was no reason to have 4 cases listed and duplicate the base of the base_cmd
@tfoote
Copy link
Member

tfoote commented Jun 7, 2018

Good catch, I updated it for a slightly more compact implementation.

@mathias-luedtke
Copy link
Contributor Author

The same structure is used in redhat.py, but without the typo.
The test failure is unrelated.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks I retriggered the failed test that failed in the setup phase.

We could clean up the redhat logic too but that could easily be a followup too.

@wjwwood
Copy link
Contributor

wjwwood commented Jun 7, 2018

@tfoote should I merge this then (you can feel free to merge it as well)? I don't have time to do a release right now. Though a rosdep release is something I should do soon, maybe just after the ROS 2 release.

@tfoote tfoote merged commit e5d6772 into ros-infrastructure:master Jun 8, 2018
@tfoote
Copy link
Member

tfoote commented Jun 8, 2018

@wjwwood I don't think it's too urgent for getting a release out. The failure mode for this is that it won't pass the quiet flags through if you use -y. All the other changes are mostly docs, and other small cleanups.

@mathias-luedtke
Copy link
Contributor Author

The failure mode for this is that it won't pass the quiet flags through if you use -y

The quiet flag was not passed at all.
This bug was present for 4 years, so a release is not urgent.

@708yamaguchi
Copy link

@tfoote @wjwwood
Could you please release 0.12.3 version of rosdep?
I have a problem that our travis fails because the travis log exceeds its maximum log length. (for example jsk-ros-pkg/jsk_robot#963 and jsk-ros-pkg/jsk_robot#969)
I think this issue will be solved if this commit is merged.

k-okada added a commit to k-okada/jsk_travis that referenced this pull request Oct 24, 2018
k-okada added a commit to k-okada/jsk_travis that referenced this pull request Oct 24, 2018
k-okada added a commit to k-okada/jsk_travis that referenced this pull request Oct 24, 2018
k-okada added a commit to jsk-ros-pkg/jsk_travis that referenced this pull request Oct 26, 2018
@mathias-luedtke
Copy link
Contributor Author

The last release is more than 7 months old..

@nuclearsandwich
Copy link
Contributor

This pull request has been released in rosdep 0.13.0. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants