-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix quiet mode of debian installer #612
Conversation
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
==========================================
+ Coverage 75.27% 75.29% +0.01%
==========================================
Files 30 30
Lines 2884 2882 -2
==========================================
- Hits 2171 2170 -1
+ Misses 713 712 -1
Continue to review full report at Codecov.
|
There was no reason to have 4 cases listed and duplicate the base of the base_cmd
Good catch, I updated it for a slightly more compact implementation. |
The same structure is used in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks I retriggered the failed test that failed in the setup phase.
We could clean up the redhat logic too but that could easily be a followup too.
@tfoote should I merge this then (you can feel free to merge it as well)? I don't have time to do a release right now. Though a rosdep release is something I should do soon, maybe just after the ROS 2 release. |
@wjwwood I don't think it's too urgent for getting a release out. The failure mode for this is that it won't pass the quiet flags through if you use |
The quiet flag was not passed at all. |
@tfoote @wjwwood |
apply ros-infrastructure/rosdep#612 to enable rosdep quiet mode
The last release is more than 7 months old.. |
This pull request has been released in rosdep 0.13.0. Thanks for contributing! |
No description provided.