Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 F632 error #659

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Conversation

at-wat
Copy link
Contributor

@at-wat at-wat commented Feb 10, 2019

Master branch and PR builds are failing due to the following flake8 error.

https://travis-ci.org/ros-infrastructure/rosdep/jobs/490897551#L546

/home/travis/build/ros-infrastructure/rosdep/src/rosdep2/main.py:350:16: F632 use ==/!= to compare str, bytes, and int literals
            if key is 'source':
               ^
flake8 reported 1 errors

@codecov-io
Copy link

codecov-io commented Feb 10, 2019

Codecov Report

Merging #659 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #659   +/-   ##
=======================================
  Coverage   75.19%   75.19%           
=======================================
  Files          30       30           
  Lines        2890     2890           
=======================================
  Hits         2173     2173           
  Misses        717      717
Impacted Files Coverage Δ
src/rosdep2/main.py 48.49% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbb106...9438061. Read the comment docs.

Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! Merging despite the codecov failure.

@wjwwood wjwwood merged commit 6d41913 into ros-infrastructure:master Feb 11, 2019
@at-wat at-wat deleted the fix-flake8-error branch February 12, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants