Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a few RHEL clones #802

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Add support for a few RHEL clones #802

merged 2 commits into from
Apr 6, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 31, 2021

In addition to CentOS, this change adds support for a few other RHEL clones: AlmaLinux, Oracle Linux, and Rocky Linux.

In addition to CentOS, this change adds support for a few other RHEL
clones: AlmaLinux, Oracle Linux, and Rocky Linux.
@cottsay cottsay self-assigned this Mar 31, 2021
tfoote
tfoote previously requested changes Mar 31, 2021
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one requested tweak. I'm find with a different name too if there's something clearer.

src/rosdep2/platforms/redhat.py Outdated Show resolved Hide resolved
src/rosdep2/platforms/redhat.py Outdated Show resolved Hide resolved
src/rosdep2/platforms/redhat.py Outdated Show resolved Hide resolved
@cottsay cottsay requested a review from tfoote April 1, 2021 00:51
@cottsay cottsay dismissed tfoote’s stale review April 6, 2021 17:35

All comments addressed

@cottsay cottsay merged commit 4b6a4f0 into master Apr 6, 2021
@cottsay cottsay deleted the cottsay/rhel_clones branch April 6, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants