Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version string for npm by decoding bytes #814

Conversation

christophebedard
Copy link
Member

Before:

$ rosdep --all-versions
0.20.1

Versions of installers:
  apt-get 2.0.5
  pip 21.0.1
  setuptools 53.0.0
  gem 3.1.2
  npm b'6.13.4'

After:

$ rosdep --all-versions
0.20.1

Versions of installers:
  apt-get 2.0.5
  pip 21.0.1
  setuptools 53.0.0
  gem 3.1.2
  npm 6.13.4

Signed-off-by: Christophe Bedard [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #814 (60eeebd) into master (30a25a7) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #814   +/-   ##
=======================================
  Coverage   74.96%   74.96%           
=======================================
  Files          42       42           
  Lines        3283     3283           
=======================================
  Hits         2461     2461           
  Misses        822      822           
Impacted Files Coverage Δ
src/rosdep2/platforms/npm.py 79.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a25a7...60eeebd. Read the comment docs.

@nuclearsandwich
Copy link
Contributor

Thanks!

@nuclearsandwich nuclearsandwich merged commit e17b3e9 into ros-infrastructure:master Jun 25, 2021
@christophebedard christophebedard deleted the fix-npm-version-string branch June 25, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants