Correctly detect when gem is not available #823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #821
Currently, when trying to install dependencies from the
gem
installer whengem
isn't installed, we get this:This is with a workspace that has a single
package.xml
file with a singlegem
dependency:<depend>metaruby</depend>
. The error message isn't really clear; users shouldn't really be asked to open an issue in this case.This fix is just doing what the
pip
installer does: ifgem
isn't installed, then none of the resolved packages are currently installed on the system, so we can simply return right away. Later on, when we try to install them, we finally get to raise an error saying thatgem
isn't installed (inGemInstaller.get_install_command()
). We get this:This is the same as #822.
Signed-off-by: Christophe Bedard [email protected]