Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI platforms. #843

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

nuclearsandwich
Copy link
Contributor

The setup-python action has dropped 2.7 on macOS.
Aside from that, while it's possible for the exclude clause to be more
succinct in practice it has been more difficult to reason about.

The changes match those of catkin_pkg#318.
Python 3.7 testing on ubuntu-latest is meant to cover Debian Buster.

Beyond that the full changes are enumerated below

CI platforms before:

  • ubuntu-18.04
    • python 2.7
    • python 3.6
    • python 3.7
    • python 3.8
    • python 3.9
  • ubuntu-20.04
    • python 3.8
    • python 3.9
  • macos-latest
    • python 2.7
    • python 3.7
    • python 3.8
    • python 3.9

CI platforms after:

  • ubuntu-18.04
    • python 2.7
    • python 3.6
  • ubuntu-latest
    • python 3.7
    • python 3.8
    • python 3.9
  • macos-latest
    • python 3.7
    • python 3.8
    • python 3.9

The setup-python action has dropped 2.7 on macOS.
Aside from that, while it's possible for the exclude clause to be more
succinct in practice it has been more difficult to reason about.

The changes match those of [catkin_pkg#318].
Python 3.7 testing on ubuntu-latest is meant to cover Debian Buster.

Beyond that the full changes are enumerated below

CI platforms before:
* ubuntu-18.04
  * python 2.7
  * python 3.6
  * python 3.7
  * python 3.8
  * python 3.9
* ubuntu-20.04
  * python 3.8
  * python 3.9
* macos-latest
  * python 2.7
  * python 3.7
  * python 3.8
  * python 3.9

CI platforms after:
* ubuntu-18.04
  * python 2.7
  * python 3.6
* ubuntu-latest
  * python 3.7
  * python 3.8
  * python 3.9
* macos-latest
  * python 3.7
  * python 3.8
  * python 3.9

[catkin_pkg#318]: ros-infrastructure/catkin_pkg#318
@nuclearsandwich nuclearsandwich self-assigned this Dec 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #843 (2aa7d44) into master (be780c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #843   +/-   ##
=======================================
  Coverage   74.96%   74.96%           
=======================================
  Files          42       42           
  Lines        3311     3311           
=======================================
  Hits         2482     2482           
  Misses        829      829           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be780c4...2aa7d44. Read the comment docs.

@nuclearsandwich nuclearsandwich merged commit 513b759 into master Dec 9, 2021
@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/refactor-ci-platforms branch December 10, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants