Improve consistency of stderr usage #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the most part, common error messages are already getting written to stderr. This change makes an effort to move the remaining errors and warnings to stderr as well.
cottsay
force-pushed
the
cottsay/stderr
branch
from
a82d017 to
09e0623
Compare
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 75.03% 75.03%
=======================================
Files 42 42
Lines 3333 3333
=======================================
Hits 2501 2501
Misses 832 832
Continue to review full report at Codecov.
|
nuclearsandwich
approved these changes
May 16, 2022
There was a problem hiding this comment.
Big picture I think it would be nice to move to an output framework for logging output like bloom does so that we're standardizing / centralizing this info rather than having to remember sys.stderr everywhere but this is doubtless an improvement over the status quo.
I spent longer than is reasonable trying to grep through and find other missed instances of this and did not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the most part, common error messages are already getting written to stderr. This change makes an effort to move the remaining errors and warnings to stderr as well.