Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias Raspbian to Debian #867

Merged
merged 2 commits into from
May 16, 2022
Merged

Alias Raspbian to Debian #867

merged 2 commits into from
May 16, 2022

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Apr 11, 2022

Debian is the upstream source for Debian packages.

OS_RASPBIAN was added to rospkg in ros-infrastructure/rospkg#244 and was released in 1.4.0.

Note that there aren't any detectors behind OS_RASPBIAN right now. It will be a breaking change for rospkg to switch detecting Raspbian as debian and start detecting as raspbian instead, and this change prepares for that eventuality.

Debian is the upstream source for Debian packages.
@cottsay cottsay self-assigned this Apr 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #867 (97e5052) into master (9342649) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
- Coverage   75.03%   75.02%   -0.02%     
==========================================
  Files          42       42              
  Lines        3333     3339       +6     
==========================================
+ Hits         2501     2505       +4     
- Misses        832      834       +2     
Impacted Files Coverage Δ
src/rosdep2/platforms/debian.py 78.73% <66.66%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9342649...97e5052. Read the comment docs.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for remembering to update the minimum rospkg version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants