Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Python 3 version in stdeb to 3.6 #879

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jun 23, 2022

Python 3.6 is the Python 3 version packaged for Bionic, and it is the minimum version we're running CI for.

@cottsay cottsay requested a review from nuclearsandwich June 23, 2022 17:12
@cottsay cottsay self-assigned this Jun 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #879 (ea44f35) into master (b2ee64f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   74.82%   74.82%           
=======================================
  Files          44       44           
  Lines        3360     3360           
=======================================
  Hits         2514     2514           
  Misses        846      846           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ee64f...ea44f35. Read the comment docs.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f-striiiiiiiiiiiiings 🚀

@cottsay
Copy link
Member Author

cottsay commented Jun 24, 2022

f-striiiiiiiiiiiiings

Too bad we still support Python 2 here...

@cottsay cottsay changed the title Bump minimum Python version in stdeb to 3.6 Bump minimum Python 3 version in stdeb to 3.6 Jun 24, 2022
@cottsay cottsay merged commit 4d95953 into master Jun 24, 2022
@cottsay cottsay deleted the cottsay/target-py branch June 24, 2022 02:23
@nuclearsandwich
Copy link
Contributor

Too bad we still support Python 2 here...

FFFFFFFFFFFFFFFFFFFFFFFFFf, strings

russkel pushed a commit to Greenroom-Robotics/rosdep that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants