Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out an independent function to fetch a distribution cache file #135

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Factor out an independent function to fetch a distribution cache file #135

merged 2 commits into from
Mar 30, 2019

Conversation

andre-rosa
Copy link
Contributor

  • No functional change and no side effects
  • Decrease file manipulation scope by closing it just after reading
  • Will be used by OpenEmbedded support in superflore

andre-rosa added a commit to lgsvl/superflore that referenced this pull request Mar 29, 2019
@andre-rosa
Reuse rosdistro functionality to fetch a distribution cache file
41581f4 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Mar 30, 2019
@andre-rosa
Reuse rosdistro functionality to fetch a distribution cache file
d5561da 
  * Depends on ros-infrastructure/rosdistro#135
@andre-rosa andre-rosa force-pushed the fetch_distribution_cache_file branch from 6f2ac41 to ca09082 Compare March 30, 2019 00:18
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Mar 30, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
3d64ab2 
  * Depends on ros-infrastructure/rosdistro#135
@andre-rosa
Factor out an independent function to get a distribution cache string
cd981bc 
  * No functional change and no side effects
  * Decrease file manipulation scope by closing it just after reading
  * Will be used by OpenEmbedded support in superflore
@andre-rosa andre-rosa force-pushed the fetch_distribution_cache_file branch from ca09082 to cd981bc Compare March 30, 2019 00:19
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Mar 30, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
d4f6fae 
  * Depends on ros-infrastructure/rosdistro#135
@dirk-thomas
Copy link
Member

Thank you for the improvement.

@dirk-thomas dirk-thomas merged commit e03a868 into ros-infrastructure:master Mar 30, 2019
@andre-rosa
Copy link
Contributor Author

Wow, thank you @dirk-thomas for being so diligent!

@andre-rosa andre-rosa deleted the fetch_distribution_cache_file branch March 30, 2019 00:25
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 2, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
2148ddc 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 2, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
8850fa2 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 2, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
3770809 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 2, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
d5d1917 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 3, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
a0c1576 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 3, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
0340ee2 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 3, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
84ce14d 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 8, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
be00f1f 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 9, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
9a8fbcb 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 11, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
372a6ff 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 20, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
c7bff9a 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 23, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
afae2ec 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 24, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
f3fbb28 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 24, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
8207479 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 24, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
292b1cc 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 25, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
7237a06 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 25, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
466da0b 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request Apr 26, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
ae317b8 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request May 1, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
baf95a2 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request May 4, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
b76cde3 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request May 6, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
7497ea1 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request May 10, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
28a85da 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request May 10, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
e5e68ec 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request May 10, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
41827c4 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request May 16, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
547beba 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request May 20, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
bfed4bf 
  * Depends on ros-infrastructure/rosdistro#135
andre-rosa added a commit to lgsvl/superflore that referenced this pull request May 22, 2019
@andre-rosa
Reuse rosdistro functionality to get a distribution cache string
24aebcb 
  * Depends on ros-infrastructure/rosdistro#135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andre-rosa @dirk-thomas