Various Cleanups #105
Merged
Various Cleanups #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
allenh1
force-pushed
the
various-cleanups
branch
2 times, most recently
from
cc2f96e to
5eaee18
Compare
allenh1
force-pushed
the
various-cleanups
branch
from
0b3ad4b to
ac010ca
Compare
tfoote
previously approved these changes
Dec 28, 2017
| @@ -123,7 +123,7 @@ def get_ebuild_text(self, distributor, license_text): | |||
| if len(split) > 1: | |||
| # they did something like "BSD,GPL,blah" | |||
| ret += 'LICENSE="( ' | |||
| ret += ' '.join([get_license(l) for l in split]) | |||
| ret += ' '.join([get_license(l.lstrip()) for l in split]) | |||
There was a problem hiding this comment.
Why only a lstrip here? You might as well strip both ends of the tokens.
There was a problem hiding this comment.
That's a good point. Fixed.
tfoote
approved these changes
Dec 28, 2017
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Strip spaces inserted in a comma separated list. * Move a TODO to the appropriate place. * Remove unused functions. * Remove unnecessary newline. * Remove unused imports. * Fix logic in case one of the caches is missing the entry. * Cleanups after running vulture. * Remove unused script. * Strip both sides of the string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some cleanup prepping for a new release. I'll update this as I notice things finishing the currently open PR's.