Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav2_msgs: Fix compilation on Windows #4843

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

traversaro
Copy link
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses None
Primary OS tested on Windows
Robotic platform tested on None
Does this PR contain AI generated software? No)

Description of contribution in a few bullet points

-Wno-error=deprecated is a option supported by GCC and Clang, so it should only be passed when GCC or Clang is used.

Description of documentation updates required from your changes

None

Future work that may be required in bullet points

None

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Silvio Traversaro <[email protected]>
@traversaro traversaro changed the title Fix compilation on Windows nav2_msgs: Fix compilation on Windows Jan 10, 2025
@SteveMacenski SteveMacenski merged commit 408fbb8 into ros-navigation:main Jan 10, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants