Export a modern CMake target instead of variables and install includes to include/${PROJECT_NAME} #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <[email protected]>
|
CI (build:
|
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
sloretz
changed the title
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
gbiggs
approved these changes
Dec 24, 2021
gbiggs
deleted the
camera_calibration_parser__export_targets_not_variables
branch
|
Ahh oops! I hadn't re-run CI after making a bunch of changes. Here's a bunch of jobs - if they pass no need to revert :)
|
|
Sorry about that! I tested locally and it built so I got over-enthusiastic. |
|
All passing, so all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ament/ament_cmake#365
Part of ament/ament_cmake#292
Part of ros2/ros2#1150
This makes
camera_calibration_parsersexport a modern CMake target instead of old-style variables. It also makes it install includes toinclude/${PROJECT_NAME}to mitigate include directory search order issues when overriding packages.