Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run either apt or dnf update with or without sudo #881

Merged
merged 1 commit into from
Jun 11, 2024
Merged

run either apt or dnf update with or without sudo #881

merged 1 commit into from
Jun 11, 2024

Conversation

christianrauch
Copy link
Contributor

@christianrauch christianrauch marked this pull request as ready for review June 5, 2024 19:17
@christianrauch christianrauch requested a review from a team as a code owner June 5, 2024 19:17
@christianrauch christianrauch requested review from MichaelOrlov and jhdcs and removed request for a team June 5, 2024 19:17
@christianrauch christianrauch marked this pull request as draft June 6, 2024 19:51
@christianrauch christianrauch marked this pull request as ready for review June 6, 2024 20:25
@christianrauch
Copy link
Contributor Author

I am getting CI errors such as:

TypeError: OptionManager.__init__() got an unexpected keyword argument 'prog'

and Ubuntu and:

ERROR:colcon.colcon_notification.desktop_notification.terminal_notifier:Could not find the colcon-terminal-notifier.app in the install prefix '/opt/homebrew'

on macOS.

I don't see how they are related or could be introduced by the PR.

The CI is also already failing on master: https://github.com/ros-tooling/action-ros-ci/actions/runs/9465322283.

christophebedard
christophebedard approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I was waiting for the setup-ros PR to be ready/merged, but I guess it's not required. Would you like it to be merged now?

@christophebedard
Copy link
Member

christophebedard commented Jun 11, 2024 •
edited
Loading

Yeah, macOS is broken, and the failing Ubuntu jobs are known too.

@christianrauch
Copy link
Contributor Author

This looks good to me. I was waiting for the setup-ros PR to be ready/merged, but I guess it's not required. Would you like it to be merged now?

If you are ok with it, we can merge now since the action can be used without ros-tooling/setup-ros anyway.

@christophebedard christophebedard merged commit 6074655 into ros-tooling:master Jun 11, 2024
32 of 38 checks passed
@christianrauch christianrauch deleted the dnf_update branch June 11, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros-tooling/reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros-tooling/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianrauch @christophebedard