Install numpy when setup-ros runs #129
Conversation
Signed-off-by: Thomas Moulard <[email protected]>
| @@ -40,6 +40,7 @@ const pip3Packages: string[] = [ | |||
| "mock", | |||
| "mypy", | |||
| "nose", | |||
| "numpy", | |||
There was a problem hiding this comment.
adding numpy here
There was a problem hiding this comment.
One thing I don't understand is how the ROS2 Wiki doesn't have this listed as a dependency to install, so what else would be pulling it in? Or maybe it's just missing from their steps?
| @@ -13,7 +13,7 @@ const binaryReleases: { [index: string]: string } = { | |||
| "https://github.com/ros2/ros2/releases/download/release-eloquent-20200124/ros2-eloquent-20200124-windows-release-amd64.zip", | |||
| }; | |||
|
|
|||
| const pip3Packages: string[] = ["lxml", "netifaces", "numpy"]; | |||
| const pip3Packages: string[] = ["lxml", "netifaces"]; | |||
There was a problem hiding this comment.
no need to keep it in the windows-only list anymore
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 8 8
Lines 123 123
Branches 6 6
=======================================
Hits 121 121
Misses 2 2
Continue to review full report at Codecov.
|
|
Should fix https://github.com/ros-tooling/libstatistics_collector/pull/10/checks?check_run_id=612846571 |
No description provided.