Pin flake8 version #195
Merged
Pin flake8 version #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 93.61% 93.61%
=======================================
Files 8 8
Lines 141 141
Branches 8 8
=======================================
Hits 132 132
Misses 9 9
Continue to review full report at Codecov.
|
zmichaels11
approved these changes
Jun 13, 2020
thomas-moulard
force-pushed
the
tmoulard/flake8
branch
from
d69a2f6 to
9fd7fde
Compare
ament_flake8 is incompatible with recent versions of flake8, see e.g. ros-tooling/cross_compile#192 for instance. Signed-off-by: Thomas Moulard <[email protected]>
thomas-moulard
force-pushed
the
tmoulard/flake8
branch
from
9fd7fde to
04409c3
Compare
jikawa-az
pushed a commit
that referenced
this pull request
Jun 23, 2020
ament_flake8 is incompatible with recent versions of flake8, see e.g. ros-tooling/cross_compile#192 for instance. Signed-off-by: Thomas Moulard <[email protected]> Signed-off-by: Ikawa <[email protected]>
jikawa-az
added a commit
that referenced
this pull request
Jun 24, 2020
* validate that the distribution input is correct * add distribution list and separate validation function * run prettier and lint * revert index.js * restore master index.js * copy index.js from master * add REP-3 and REP-2000 compliant distributions Signed-off-by: Ikawa <[email protected]> * Bump @types/node from 14.0.12 to 14.0.13 (#194) Signed-off-by: Ikawa <[email protected]> * Pin flake8 version (#195) ament_flake8 is incompatible with recent versions of flake8, see e.g. ros-tooling/cross_compile#192 for instance. Signed-off-by: Thomas Moulard <[email protected]> Signed-off-by: Ikawa <[email protected]> * validate that the distribution input is correct Signed-off-by: Ikawa <[email protected]> * add distribution list and separate validation function Signed-off-by: Ikawa <[email protected]> * run prettier and lint Signed-off-by: Ikawa <[email protected]> * revert index.js Signed-off-by: Ikawa <[email protected]> * restore master index.js Signed-off-by: Ikawa <[email protected]> * copy index.js from master Signed-off-by: Ikawa <[email protected]> * add REP-3 and REP-2000 compliant distributions Signed-off-by: Ikawa <[email protected]> * Modify comments Signed-off-by: Jesse Ikawa <[email protected]> * add unit tests Signed-off-by: Jesse Ikawa <[email protected]> * Update src/utils.ts Co-authored-by: Zachary Michaels <[email protected]> Co-authored-by: Ikawa <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Thomas Moulard <[email protected]> Co-authored-by: Zachary Michaels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.