Windows: Add in registry key that is expected for ROS 2 Chocolatey. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment has more information about why. Signed-off-by: Chris Lalancette <[email protected]>
emersonknapp
approved these changes
Jun 24, 2020
zmichaels11
approved these changes
Jun 25, 2020
|
Can someone merge this one as well? Thanks! |
|
Thank you! |
|
I also released 0.0.25 so you have a release with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows: Add in registry key that is expected for ROS 2 Chocolatey.
The ROS 2 NUGET Chocolatey packages expect a registry entry of
HKCU\SOFTWARE\Kitware\CMake to exist; if it doesn't, they don't
properly register themselves with CMake and thus downstream software
can't properly find them. The Windows image that is currently available
to GitHub actions (https://github.com/actions/virtual-environments/blob/win19/20200608.1/images/win/Windows2019-Readme.md)
doesn't seem to have this key, so add it by hand here.