-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modify macos ci #675
fix: modify macos ci #675
Conversation
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: wep21 <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
This reverts commit 4344279. Signed-off-by: wep21 <[email protected]>
It's still using the system Python 3.12 even though we're installing 3.10: https://github.com/ros-tooling/setup-ros/actions/runs/8881922426/job/24385408636?pr=675#step:5:1251. Some possible solutions:
|
Looks like it still has some Python 3.12 stuff: https://github.com/ros-tooling/setup-ros/actions/runs/8882209200/job/24386325507?pr=675#step:5:1274. I'm guessing |
Signed-off-by: wep21 <[email protected]>
I just want to confirm that you're happy with this. CI passes and I don't see any references to the system |
The changes are
|
For now, it is unnecessary to make break-system-package true because it is necessary for python3.12. |
I think it's fine, we can leave it there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix and for the perseverance! 😁
I released this as |
This PR fixes:
It also pins Python to 3.10 as per REP 2000: https://www.ros.org/reps/rep-2000.html#rolling-ridley-june-2020-ongoing